[Tunnel] init module #469
Open
[Tunnel] init module #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Tunnel] fix produce packet
RogerKSI
requested changes
Nov 18, 2024
RogerKSI
requested changes
Nov 18, 2024
RogerKSI
requested changes
Nov 18, 2024
taobun
reviewed
Nov 19, 2024
added 3 commits
November 19, 2024 13:37
taobun
reviewed
Nov 22, 2024
taobun
reviewed
Nov 22, 2024
RogerKSI
requested changes
Nov 22, 2024
x/tunnel/types/tunnel.go
Outdated
Comment on lines
93
to
112
| // Validate validates the total fees | ||
| func (tf TotalFees) Validate() error { | ||
| if !tf.TotalPacketFee.IsValid() { | ||
| return fmt.Errorf("invalid total packet fee: %s", tf.TotalPacketFee) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // ValidateInterval validates the interval. | ||
| func ValidateInterval(interval uint64, params Params) error { | ||
| if interval < params.MinInterval || interval > params.MaxInterval { | ||
| return ErrIntervalOutOfRange.Wrapf( | ||
| "max %d, min %d, got %d", | ||
| params.MaxInterval, | ||
| params.MinInterval, | ||
| interval, | ||
| ) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
these functions should not be here?
There was a problem hiding this comment.
any suggest on where should I put ValidateInterval?
taobun
reviewed
Nov 22, 2024
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
Create Tunnel module
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)