Skip to content

Commit

Permalink
Merge "ion-unit-tests: Add heap id verification test." am: ff0b875 [f…
Browse files Browse the repository at this point in the history
…ormerly 3201740]

am: 77e8def [formerly e677c33]

Change-Id: Idd1cf7e930e7452d09fd0618d4355aff94c3e96b

Former-commit-id: ca59dd1
  • Loading branch information
patils authored and android-build-merger committed Sep 16, 2019
2 parents 8661655 + 77e8def commit 5bf568e
Showing 1 changed file with 23 additions and 2 deletions.
25 changes: 23 additions & 2 deletions libion/tests/heap_query.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/

#include <gtest/gtest.h>

#include <ion/ion.h>
#include "ion_test_fixture.h"

class HeapQuery : public IonTest {};
Expand All @@ -23,5 +25,24 @@ TEST_F(HeapQuery, AtleastOneHeap) {
ASSERT_GT(ion_heaps.size(), 0);
}

// TODO: Check if we expect some of the default
// heap types to be present on all devices.
// TODO: Adjust this test to account for the range of valid carveout and DMA heap ids.
TEST_F(HeapQuery, HeapIdVerify) {
for (const auto& heap : ion_heaps) {
SCOPED_TRACE(::testing::Message() << "Invalid id for heap:" << heap.name << ":" << heap.type
<< ":" << heap.heap_id);
switch (heap.type) {
case ION_HEAP_TYPE_SYSTEM:
ASSERT_TRUE((1 << heap.heap_id) & ION_HEAP_SYSTEM_MASK);
break;
case ION_HEAP_TYPE_SYSTEM_CONTIG:
ASSERT_TRUE((1 << heap.heap_id) & ION_HEAP_SYSTEM_CONTIG_MASK);
break;
case ION_HEAP_TYPE_CARVEOUT:
ASSERT_TRUE((1 << heap.heap_id) & ION_HEAP_CARVEOUT_MASK);
break;
case ION_HEAP_TYPE_DMA:
ASSERT_TRUE((1 << heap.heap_id) & ION_HEAP_TYPE_DMA_MASK);
break;
}
}
}

0 comments on commit 5bf568e

Please sign in to comment.