Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): portable config not creating folder correctly #139

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

bambanah
Copy link
Owner

@bambanah bambanah commented Oct 30, 2024

  • Add separator after config folder path when running cli in portable mode
    • configconfig.json -> config/config.json
  • Better handle error when trying to download spotify link without spotify credentials set
  • Exit process faster when download finished
    • Was previously hanging for a non-zero amount of time (and was annoying)

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 53be96e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
deemix-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bambanah bambanah force-pushed the fix-cli-config-folder branch from 4ee0ced to 53be96e Compare October 30, 2024 06:51
@bambanah bambanah merged commit f120283 into main Oct 30, 2024
1 check passed
@bambanah bambanah deleted the fix-cli-config-folder branch October 30, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant