ci(repo): refactor pr ci using turborepo

bambanah · Sep 12, 2024 · 2e84312 · 2e84312
1 parent 1992566
commit 2e84312
Show file tree

Hide file tree

Showing 8 changed files with 27 additions and 19 deletions.
diff --git a/.github/workflows/lint-test-build.yml → .github/workflows/pull-request.yml b/.github/workflows/lint-test-build.yml → .github/workflows/pull-request.yml
@@ -9,7 +9,7 @@ env:
   HUSKY: 0
 
 jobs:
-  lint-test-build:
+  pull-request:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -21,6 +21,4 @@ jobs:
 
       - run: pnpm install --frozen-lockfile
 
-      - run: pnpm lint
-      # - run: pnpm test
-      - run: pnpm build
+      - run: pnpm run ci
diff --git a/deemix/package.json b/deemix/package.json
@@ -9,7 +9,7 @@
 	"scripts": {
 		"dev": "tsup src/index.ts --format esm --dts --watch",
 		"build": "tsup src/index.ts --format esm --dts",
-		"lint:ts": "tsc --noEmit"
+		"type-check": "tsc --noEmit"
 	},
 	"author": "RemixDev",
 	"license": "GPL-3.0-or-later",

diff --git a/deezer-sdk/package.json b/deezer-sdk/package.json
@@ -11,7 +11,7 @@
 		"build": "tsc",
 		"test": "vitest run",
 		"test:watch": "vitest",
-		"lint:ts": "tsc --noEmit"
+		"type-check": "tsc --noEmit"
 	},
 	"repository": {
 		"type": "git",

diff --git a/gui/package.json b/gui/package.json
@@ -12,7 +12,8 @@
 		"dev": "electron .",
 		"build": "node ./scripts/build.mjs --mode production",
 		"package": "electron-forge package",
-		"make": "electron-forge make"
+		"make": "electron-forge make",
+		"type-check": "tsc --noEmit"
 	},
 	"devDependencies": {
 		"@electron-forge/cli": "^7.3.1",

diff --git a/gui/tsconfig.json b/gui/tsconfig.json
@@ -6,7 +6,6 @@
 		"strict": false,
 		"esModuleInterop": true,
 		"declaration": true,
-		"emitDeclarationOnly": true,
 		"resolveJsonModule": true,
 		"rootDir": "./src",
 		"outDir": "./dist"

diff --git a/package.json b/package.json
@@ -11,14 +11,12 @@
 		"dev": "pnpm -r --parallel --filter=!deemix-gui dev",
 		"dev:gui": "pnpm -C gui dev",
 		"build": "turbo run build",
+		"lint": "turbo run lint",
+		"type-check": "turbo run type-check",
+		"test": "turbo run test",
 		"package": "turbo run package",
 		"make": "turbo run make",
-		"build:gui": "pnpm build && pnpm -C gui build",
-		"start": "pnpm -C webui start",
-		"test": "pnpm -C webui test",
-		"lint": "run-s lint:*",
-		"lint:es": "eslint .",
-		"lint:ts": "pnpm -r lint:ts",
+		"ci": "turbo run lint type-check build",
 		"prepare": "husky"
 	},
 	"devDependencies": {

diff --git a/turbo.json b/turbo.json
@@ -1,15 +1,27 @@
 {
 	"$schema": "https://turborepo.org/schema.json",
 	"tasks": {
+		"lint": {
+			"outputs": []
+		},
 		"build": {
 			"dependsOn": ["^build"],
 			"outputs": ["dist/**"]
 		},
+		"type-check": {
+			"dependsOn": ["^build"],
+			"outputs": []
+		},
+		"test": {
+			"dependsOn": ["^build"]
+		},
 		"package": {
-			"dependsOn": ["build", "^package"]
+			"dependsOn": ["build", "^build"],
+			"outputs": ["dist/**", "out/**"]
 		},
 		"make": {
-			"dependsOn": ["build", "^make"]
+			"dependsOn": ["build", "^build"],
+			"outputs": ["dist/**", "out/**"]
 		}
 	}
 }
diff --git a/webui/package.json b/webui/package.json
@@ -13,9 +13,9 @@
 		"test": "jest",
 		"test-watch": "jest --watch",
 		"testlang": "node ./tests/testlang.js",
-		"lint:ts": "run-p lint:client lint:server",
-		"lint:client": "vue-tsc --noEmit -p src/client/tsconfig.json",
-		"lint:server": "tsc --noEmit -p src/server/tsconfig.json"
+		"type-check": "run-p type-check:*",
+		"type-check:client": "vue-tsc --noEmit -p src/client/tsconfig.json",
+		"type-check:server": "tsc --noEmit -p src/server/tsconfig.json"
 	},
 	"nodemonConfig": {
 		"watch": [