Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix params with stringified keys that are part of the URL getting appended to query #119

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

balvig
Copy link
Owner

@balvig balvig commented Apr 19, 2021

What

Before

Base.with("recipes/:recipe_id/image").where("recipe_id" => 1).to_a
# => GET /recipes/1/image?recipe_id=1

After

Base.with("recipes/:recipe_id/image").where("recipe_id" => 1).to_a
# => GET /recipes/1/image

@coveralls
Copy link

coveralls commented Apr 19, 2021

Coverage Status

Coverage increased (+0.001%) to 99.641% when pulling 0d18043 on jb/fix-params-with-stringified-keys-that-are-part-of-t into e83847d on main.

@balvig balvig force-pushed the jb/fix-params-with-stringified-keys-that-are-part-of-t branch from 9e8aacf to 1772082 Compare April 19, 2021 06:20
@balvig balvig marked this pull request as ready for review April 19, 2021 06:22
@balvig balvig force-pushed the jb/fix-params-with-stringified-keys-that-are-part-of-t branch from 1772082 to 0d18043 Compare April 19, 2021 06:26
@balvig balvig merged commit 9d256d4 into main Apr 19, 2021
@balvig balvig deleted the jb/fix-params-with-stringified-keys-that-are-part-of-t branch April 19, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants