This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Upgrade Datasette #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earthboundkid
commented
Apr 15, 2018
| @@ -13,7 +13,7 @@ | |||
| <form class="sql" action="/{{ database }}-{{ database_hash }}" method="get"> | |||
| <h3>Custom SQL query</h3> | |||
| <p>Note: Database uses <a href="https://www.sqlite.org/lang.html">SQLite</a> syntax.</p> | |||
| <p><textarea name="sql">select * from {{ tables[0].name|escape_table_name }}</textarea></p> | |||
| <p><textarea name="sql">select * from {{ tables[0].name|escape_sqlite }}</textarea></p> | |||
There was a problem hiding this comment.
escape_table_name was removed and replaced in the new Datasette.
earthboundkid
commented
Apr 15, 2018
templates/_rows_and_columns.html
Outdated
| {% else %} | ||
| <a href="{{ path_with_added_args(request, {'_sort': column.name, '_sort_desc': None, '_next': None}) }}" rel="nofollow">{{ name }}{% if column.name == sort_desc %} ▲{% endif %}</a> | ||
| {% endif %} | ||
| {% endif %} |
There was a problem hiding this comment.
Most of this is copy-pasta from Datasette's new default template.
earthboundkid
commented
Apr 15, 2018
|
|
||
| {% include "_codemirror_foot.html" %} | ||
| {% include "_codemirror_foot.html" %} | ||
| {% endif %} |
There was a problem hiding this comment.
Error handling was changed in the new Datasette.
|
I found a bug with sorting NULL columns. It's reported here: simonw/datasette#216 We should probably wait until that's worked out before upgrading. |
|
I just shipped Datasette 0.19 with a fix for simonw/datasette#216 |
|
Thanks, Simon! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sorting by columns.