🐛 Add tie breaker when sorting changesets by RevisionID in tests. (os…

…sf#2781) * Remove duplicate RevisionID collision from changeset tests. The map iteration order isn't deterministic and sorting the slices isn't good enough when the revision IDs are equal. Signed-off-by: Spencer Schrock <[email protected]> * remove any potential sha collisions Signed-off-by: Spencer Schrock <[email protected]> * Revert deduplications. Signed-off-by: Spencer Schrock <[email protected]> * Use ReviewPlatform as tie breaker. Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Avishay <[email protected]>
balteravishay · Apr 14, 2023 · 2411511 · 2411511
1 parent 41bc7b2
commit 2411511
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/checks/raw/code_review_test.go b/checks/raw/code_review_test.go
@@ -358,6 +358,9 @@ func Test_getChangesets(t *testing.T) {
 		changesets := getChangesets(tt.commits)
 		if !cmp.Equal(tt.expected, changesets,
 			cmpopts.SortSlices(func(x, y checker.Changeset) bool {
+				if x.RevisionID == y.RevisionID {
+					return x.ReviewPlatform < y.ReviewPlatform
+				}
 				return x.RevisionID < y.RevisionID
 			}),
 			cmpopts.SortSlices(func(x, y clients.Commit) bool {