🐛 fix(bal-modal): opening bal-modal leads to page scroll to top

[tri-vo-mesoneer]

Current Behavior

bal-modal does not restore the scroll position.
If the page is long, then opening the modal which is in the bottom of the page, leads to the page will be scrolled to top when bal-modal is opened.

Expected Behavior

I expect that the page will keep the scroll postion when bal-modal is opened or closed.

Steps to Reproduce

1. You can open Code Sandbox in the Baloise document link.
2. Just simply add some element above bal-modal in order to make the page longer.
3. Click on button to open modal and you will see the page is scrolled to top.
   

Version

latest

Browsers

Chrome, Microsoft Edge

Device

Desktop

Code Reproduction URL

https://codesandbox.io/p/sandbox/angular-forked-p65s8z?file=%2Fsrc%2Fapp%2Fexample.component.html%3A5%2C1

Additional Information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[hirsch88]

/cib

[github-actions]

Branch fix/issue-1396 created!

[hirsch88]

A builded angular app still does scroll to the top

[hirsch88]

/cib

[github-actions]

Branch fix/issue-1396 created!

[hirsch88]

Could not reproduce the issue
@FilipMarkovski please try to update the Design System and clear the cache.

[hirsch88]

created a version with logs to investigate the angular issue
16.2.0-snapshot.1402-c52849609

[hirsch88]

@FilipMarkovski 16.2.0-snapshot.1402-8b748b200

[FilipMarkovski]

@hirsch88 If you can, keep this issue open until the required libraries are updated to the latest version of Design System, because that change will come in some of the future sprints.

[FilipMarkovski]

The problem is definitely within the two internal libraries that are indirectly fetching the legacy @baloise/design-system-components. We just saw the results after we got rid of both of them.

If you want, you can close this ticket as "resolved". For anybody else reading this issue, run "npm ls @baloise/design-system-components". If one of the dependencies are still fetching design system < v16, you should upgrade them.