Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[URGENT] Added explicit class-transform dependency #65

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

mooyoul
Copy link
Contributor

@mooyoul mooyoul commented Jun 25, 2019

Is it a breaking change?: NO

Why did you make these changes?

About 23 hours ago, class-validator-jsonschema released a new version (v1.3.0, minor version update). They changed dependency policy. Two critical packages (class-validator and class-transformer) were moved to peerDependencies from dependencies section. It breaks corgi dependent service builds because we never added class-transformer.

What's changed in these changes?

  • Added explicit class-validator and class-transform dependency

What do you especially want to get reviewed?

N/A

Is there any other comments that every teammate should know?

Due to severity, I will release a new corgi release without review.

Submission Type

  • Bugfix

All Submissions

  • Have you added an explanation of what your changes?
  • Have you written new tests for your changes, as applicable?
  • Have you checked potential side effects that could make bad impacts to other services?

@mooyoul mooyoul added the Urgent label Jun 25, 2019
@mooyoul mooyoul merged commit 6576f71 into master Jun 25, 2019
@mooyoul mooyoul deleted the hotfix/class-validator-jsonschema-130 branch June 25, 2019 09:32
@mooyoul
Copy link
Contributor Author

mooyoul commented Jun 25, 2019

Released to v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants