Skip to content

Commit

Permalink
[ci skip] add PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
mooyoul committed Feb 26, 2019
1 parent ffcdbe9 commit 80db56c
Showing 1 changed file with 41 additions and 0 deletions.
41 changes: 41 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
## BACKEND-STORY_ID One-sentence summary of changes

#### Is it a breaking change?: NO / YES

### Why did you make these changes?

Service `X` requires `Y` field from response entity of `Z` API call.

### What's changed in these changes?

I added `X` field to `Y` entity.

### What do you especially want to get reviewed?

The method of rendering `X` field

### Is there any other comments that every teammate should know?

You should use `X` field instead of using `Y` field


### Submission Type

* [ ] Bugfix
* [ ] New Feature
* [ ] Refactor

### All Submissions

* [ ] Have you added an explanation of what your changes?
* [ ] Have you written new tests for your changes, as applicable?
* [ ] Have you checked potential side effects that could make bad impacts to other services?


### New Features

* [ ] Have you configured CI/CD properly?
* [ ] Have you configured optimal memory size and timeouts of Lambda Function?
* [ ] Have you grant required permissions (e.g. IAM Policy, VPC Security Group)?
* [ ] Have you made required resources (e.g. DynamoDB Table, RDS Cluster)?
* [ ] Does it requires native addons dependency?

0 comments on commit 80db56c

Please sign in to comment.