Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refator Code to use !is instead of !(<variable> is <type>) #44

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Refator Code to use !is instead of !(<variable> is <type>) #44

merged 3 commits into from
Oct 17, 2023

Conversation

Ishad-M-I-M
Copy link
Contributor

@Ishad-M-I-M Ishad-M-I-M commented Oct 9, 2023

Purpose

Fixes: ballerina-platform/ballerina-library#2952

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@Ishad-M-I-M Ishad-M-I-M requested a review from daneshk as a code owner October 9, 2023 12:08
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (98f45ae) 86.50% compared to head (fd3790a) 86.42%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #44      +/-   ##
============================================
- Coverage     86.50%   86.42%   -0.09%     
+ Complexity      713      706       -7     
============================================
  Files            56       56              
  Lines          3202     3197       -5     
  Branches        355      355              
============================================
- Hits           2770     2763       -7     
- Misses          327      329       +2     
  Partials        105      105              
Files Coverage Δ
...otoc/builder/syntaxtree/components/Expression.java 77.27% <100.00%> (-2.73%) ⬇️
...lder/syntaxtree/constants/SyntaxTreeConstants.java 100.00% <100.00%> (ø)
.../protoc/builder/syntaxtree/utils/MessageUtils.java 80.12% <100.00%> (-0.37%) ⬇️
...a/protoc/builder/syntaxtree/utils/ServerUtils.java 94.61% <100.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi merged commit ffbf33d into ballerina-platform:main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format the generated functions for oneof type
2 participants