Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BallerinaToOpenAPI]Fix mapping to application/x-www-form-urlencoded when it has response and request body in resources #926

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Mar 14, 2022

Purpose

$Subject
Fix ballerina-platform/ballerina-library#5391

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #926 (84e9b8b) into master (0b1ce13) will increase coverage by 0.12%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##             master     ballerina-platform/openapi-tools#926      +/-   ##
============================================
+ Coverage     73.80%   73.93%   +0.12%     
  Complexity      483      483              
============================================
  Files           119      119              
  Lines          7800     7795       -5     
  Branches       1272     1267       -5     
============================================
+ Hits           5757     5763       +6     
+ Misses         1558     1553       -5     
+ Partials        485      479       -6     
Impacted Files Coverage Δ
...pi/converter/service/OpenAPIRequestBodyMapper.java 87.69% <87.50%> (+4.01%) ⬆️
...enapi/converter/service/OpenAPIResponseMapper.java 85.60% <91.66%> (+0.13%) ⬆️
.../openapi/converter/utils/ConverterCommonUtils.java 57.50% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1ce13...84e9b8b. Read the comment docs.

@lnash94 lnash94 marked this pull request as draft March 14, 2022 10:55
@lnash94 lnash94 marked this pull request as ready for review March 14, 2022 11:34
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shafreenAnfar
Copy link
Contributor

Went through the test-cases and looks good to me. In addition to map we will soon support records as well.

@lnash94
Copy link
Member Author

lnash94 commented Mar 29, 2022

Thank you, I will create a task to track support for openapi tool. :)

@lnash94 lnash94 merged commit 5603f6d into ballerina-platform:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide mapping to application/x-www-form-urlencoded when it has response and request body in resources
3 participants