-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BallerinaToOpenAPI]Fix mapping to application/x-www-form-urlencoded
when it has response and request body in resources
#926
Conversation
Codecov Report
@@ Coverage Diff @@
## master ballerina-platform/openapi-tools#926 +/- ##
============================================
+ Coverage 73.80% 73.93% +0.12%
Complexity 483 483
============================================
Files 119 119
Lines 7800 7795 -5
Branches 1272 1267 -5
============================================
+ Hits 5757 5763 +6
+ Misses 1558 1553 -5
+ Partials 485 479 -6
Continue to review full report at Codecov.
|
3d63f3c
to
e634a60
Compare
e634a60
to
702ced6
Compare
...l-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIRequestBodyMapper.java
Outdated
Show resolved
Hide resolved
...-bal-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIResponseMapper.java
Show resolved
Hide resolved
...pi-cli/src/test/resources/ballerina-to-openapi/expected_gen/response/rs_with_url_encode.yaml
Outdated
Show resolved
Hide resolved
...pi-cli/src/test/resources/ballerina-to-openapi/expected_gen/response/rs_with_url_encode.yaml
Outdated
Show resolved
Hide resolved
openapi-cli/src/test/resources/ballerina-to-openapi/response/rs_with_url_encode.bal
Outdated
Show resolved
Hide resolved
openapi-cli/src/test/resources/ballerina-to-openapi/response/rs_with_url_encode.bal
Outdated
Show resolved
Hide resolved
7ea2590
to
267783a
Compare
...l-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIRequestBodyMapper.java
Outdated
Show resolved
Hide resolved
267783a
to
12e7cd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Went through the test-cases and looks good to me. In addition to |
Thank you, I will create a task to track support for openapi tool. :) |
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning