Enhance generated record name sanitisation for OAS schema name #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-tools into flattern-enable # Conflicts: # module-ballerina-openapi/Ballerina.toml # module-ballerina-openapi/CompilerPlugin.toml
…i-tools into flattern-enable # Conflicts: # openapi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/Constants.java # openapi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/OpenAPICodeGeneratorTool.java # openapi-bal-task-plugin/src/main/resources/openapi-options-schema.json # openapi-cli/src/main/java/io/ballerina/openapi/cmd/BallerinaCodeGenerator.java # openapi-cli/src/main/java/io/ballerina/openapi/cmd/BaseCmd.java # openapi-cli/src/main/java/io/ballerina/openapi/cmd/OpenApiCmd.java # openapi-cli/src/test/java/io/ballerina/openapi/CodeGeneratorTest.java # openapi-core/src/main/java/io/ballerina/openapi/core/generators/client/model/OASClientConfig.java
lnash94
force-pushed
the
flattern-enable
branch
from
d4be1b4 to
8d5ef8d
Compare
lnash94
force-pushed
the
flattern-enable
branch
from
8d5ef8d to
8a4498a
Compare
...pi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/OpenAPICodeGeneratorTool.java
Outdated
Show resolved
Hide resolved
openapi-cli/src/test/java/io/ballerina/openapi/generators/common/OASSanitizerTests.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Aug 6, 2024
...pi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/OpenAPICodeGeneratorTool.java
Outdated
Show resolved
Hide resolved
...pi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/OpenAPICodeGeneratorTool.java
Show resolved
Hide resolved
...pi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/OpenAPICodeGeneratorTool.java
Show resolved
Hide resolved
daneshk
reviewed
Aug 6, 2024
openapi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/Constants.java
Show resolved
Hide resolved
daneshk
reviewed
Aug 6, 2024
...pi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/OpenAPICodeGeneratorTool.java
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Aug 6, 2024
openapi-cli/src/main/java/io/ballerina/openapi/cmd/BaseCmd.java
Outdated
Show resolved
Hide resolved
lnash94
force-pushed
the
flattern-enable
branch
from
da37d7d to
458443f
Compare
lnash94
force-pushed
the
flattern-enable
branch
from
ac3992e to
197e782
Compare
daneshk
approved these changes
Aug 6, 2024
|
lnash94
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ballerina-platform/ballerina-library#6578
We will be adding this as experimental feature to the tool along with update 10.