-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the client method's signature to be consistent with the HTTP client #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TharmiganK
force-pushed
the
fix-client-method-signature
branch
from
April 29, 2024 16:32
901a6e9
to
aaf916a
Compare
TharmiganK
force-pushed
the
fix-client-method-signature
branch
from
April 29, 2024 16:55
aaf916a
to
7e4eeef
Compare
…ignature # Conflicts: # openapi-core/src/main/java/io/ballerina/openapi/core/generators/client/FunctionBodyGeneratorImp.java # openapi-core/src/main/java/io/ballerina/openapi/core/generators/client/parameter/RequestBodyHeaderParameter.java # openapi-core/src/main/java/io/ballerina/openapi/core/generators/document/TypesDocCommentGenerator.java
TharmiganK
force-pushed
the
fix-client-method-signature
branch
from
May 2, 2024 11:47
ac9f7df
to
a3d10ff
Compare
Quality Gate failedFailed conditions |
lnash94
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, rest of the code review and suggestions we will address via separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#6475
Example
The new generated client:
The new header and query records: