Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAS mapping for HTTP status code errors #1604

Merged
merged 13 commits into from
Feb 14, 2024

Conversation

TharmiganK
Copy link
Contributor

Purpose

$Subject

Fixes:

Example

Refer to the above issue for proposal and examples

@TharmiganK TharmiganK force-pushed the support-status-code-errors branch from 6ca8ac4 to 3f51c34 Compare February 8, 2024 10:48
@TharmiganK TharmiganK marked this pull request as ready for review February 8, 2024 10:48
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (2245a6a) 80.77% compared to head (5ec92e5) 80.82%.

Files Patch % Lines
...ice/mapper/response/utils/StatusCodeTypeUtils.java 73.33% 3 Missing and 9 partials ⚠️
...pi/service/mapper/response/ResponseMapperImpl.java 87.50% 3 Missing and 3 partials ⚠️
...enapi/service/mapper/type/ReferenceTypeMapper.java 40.00% 4 Missing and 2 partials ⚠️
...mapper/response/utils/StatusCodeResponseUtils.java 69.23% 2 Missing and 2 partials ⚠️
.../openapi/service/mapper/type/RecordTypeMapper.java 76.92% 2 Missing and 1 partial ⚠️
...ce/mapper/response/utils/StatusCodeErrorUtils.java 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1604      +/-   ##
============================================
+ Coverage     80.77%   80.82%   +0.04%     
- Complexity     1928     1951      +23     
============================================
  Files           149      154       +5     
  Lines          9990    10089      +99     
  Branches       1635     1646      +11     
============================================
+ Hits           8069     8154      +85     
- Misses         1351     1361      +10     
- Partials        570      574       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK force-pushed the support-status-code-errors branch from a16fee7 to 097d045 Compare February 13, 2024 03:50
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@dilanSachi dilanSachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TharmiganK TharmiganK merged commit a8f3e4d into master Feb 14, 2024
8 checks passed
@TharmiganK TharmiganK deleted the support-status-code-errors branch February 14, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants