Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[constraint_support] Add negative tests for constraint support #1561

Merged
merged 55 commits into from
Oct 24, 2023
Merged

[constraint_support] Add negative tests for constraint support #1561

merged 55 commits into from
Oct 24, 2023

Conversation

SachinAkash01
Copy link
Member

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

SachinAkash01 and others added 30 commits September 25, 2023 10:27
@SachinAkash01
Improve support @constraint:String {} annotation mapping to OpenAPI…
5a73980 
… Spec

- Add support for mapping Ballerina String constraints to the OpenAPI specification.
- Modify the unit tests to ensure the accuracy & reliability of `@constraint:String {}` mapping to OpenAPI spec.
- This ensures that String constraints in Ballerina are accurately reflected in OpenAPI spec.

Resolves: [#4813](ballerina-platform/ballerina-library#4813)
See also: [#4788](ballerina-platform/ballerina-library#4788)
@SachinAkash01
Add unit tests
1aaa59a
@SachinAkash01
Fix line spaces
530742e
@SachinAkash01
Resolve suggested changes
88ae2a3
@SachinAkash01
Add record type constraint mapping
353134f
@SachinAkash01
Fix Ubuntu build issue
4c924c3
@SachinAkash01
Add unit tests for constraint record types
c3a756d
@SachinAkash01
Add new line space
1c05aac
@SachinAkash01
Improve regex support
890ea97
@SachinAkash01
Add suggested changes
7e4e8bc
@SachinAkash01
Fix build issues
6ffb883
@SachinAkash01
Test case for pattern interpolations
597f54e
@SachinAkash01
Fix line space
8b2c7a9
@SachinAkash01
Handle interpolation in REGEX patterns
cf8df49
@SachinAkash01
Change variable names according to naming conventions
ceabf56
@SachinAkash01
Fix interpolation patterns
58b2e9b
@SachinAkash01
Improve tests for interpolation in regex
eb3b5a0
@SachinAkash01
Improve CHECK_INTERPOLATION pattern
41edbf9
@SachinAkash01
Reduce security hotspots
67297b6
@SachinAkash01
Improve diagnostic
4b61beb
@SachinAkash01
Improve regex patterns
260aba0
@SachinAkash01
Improve security in REGEX patterns
0af8813
@SachinAkash01
Improve interpolation tests
52e9366
@SachinAkash01
Improve diagnostic messages
bf8ce90
@SachinAkash01
Merge branch 'constraint_support' into constraint_s_s
009bfde
@SachinAkash01 @lnash94
Update openapi-cli/src/test/resources/ballerina-to-openapi/constraint…
2a10557 
…/decimalRec.bal

Co-authored-by: Sumudu Nissanka <[email protected]>
@SachinAkash01 @lnash94
Update openapi-cli/src/test/resources/ballerina-to-openapi/constraint…
123e8a6 
…/floatRec.bal

Co-authored-by: Sumudu Nissanka <[email protected]>
@SachinAkash01
Fix reviewed changes
3af7830
@SachinAkash01
Merge branch 'constraint_s_s' of https://github.com/SachinAkash01/ope…
5949344 
…napi-tools into constraint_s_s
@SachinAkash01
Improve diagnostic messages
74a4a36
SachinAkash01 and others added 19 commits October 13, 2023 10:19
@SachinAkash01
Fix build issues
42ebe86
@SachinAkash01
Naming files with proper format
f68caac
@SachinAkash01
Add negative test for REGEX patterns
e42ddda
@SachinAkash01
Fix whitespace error
a3ef54d
@SachinAkash01 @ayeshLK
Update openapi-cli/src/test/java/io/ballerina/openapi/generators/open…
3d4a7ee 
…api/NegativeConstraintTests.java

Co-authored-by: Ayesh Almeida <[email protected]>
@SachinAkash01 @lnash94
Update openapi-cli/src/test/resources/ballerina-to-openapi/constraint…
4608845 
…/arrayRec.bal

Co-authored-by: Sumudu Nissanka <[email protected]>
@SachinAkash01
Fix suggested changes
858fd56
@SachinAkash01
Add negative tests for constraint mapper
35633ca
@SachinAkash01
Changes in licence header
35ab583
@SachinAkash01
Improve comments
80972f6
@SachinAkash01
Fix newlines
afd99dd
@SachinAkash01
Remove newline
83ae971
@SachinAkash01
Remove additional lines
6d8b4f1
@SachinAkash01
Handle exceptions in negative tests
db22d4f
@SachinAkash01
fix single responsibility in methods
afc37c8
@SachinAkash01
Fix suggested changes
4ca219e
@SachinAkash01
Improve the logic in isDateConstraint()
43c87f7
@SachinAkash01 @ayeshLK
Update constant variable name used to check Date constraint annotations
d5ed7db 
Co-authored-by: Ayesh Almeida <[email protected]>
@SachinAkash01
Update OpenAPIComponentMapper.java
de2be12
@SachinAkash01
Merge branch 'constraint_support' of https://github.com/ballerina-pla…
be6823e 
…tform/openapi-tools into constraint_s

# Conflicts:
#	openapi-bal-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIComponentMapper.java
@SachinAkash01
Fix failing tests
5c9f0a1
@lnash94
Copy link
Member

lnash94 commented Oct 24, 2023

Merge this since this is feature branch

@lnash94 lnash94 closed this Oct 24, 2023
@lnash94 lnash94 reopened this Oct 24, 2023
@lnash94 lnash94 merged commit 17a9b7c into ballerina-platform:constraint_support Oct 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnash94 lnash94 lnash94 approved these changes

@hevayo hevayo Awaiting requested review from hevayo hevayo is a code owner

@NipunaRanasinghe NipunaRanasinghe Awaiting requested review from NipunaRanasinghe NipunaRanasinghe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SachinAkash01 @lnash94