Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.x] fix for mapping error status code for return nil type in Ballerina to OpenAPI spec generation #1535

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Sep 14, 2023

Purpose

Fix ballerina-platform/ballerina-library#4924

Automation tests

  • Unit tests - Added

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@github-actions github-actions bot added the Stale label Sep 29, 2023
@lnash94 lnash94 removed the Stale label Oct 2, 2023
@lnash94 lnash94 changed the base branch from master to 1.8.x October 13, 2023 16:00
@lnash94 lnash94 changed the title [master] fix for mapping error status code for return nil type in Ballerina to OpenAPI spec generation [1.8.x] fix for mapping error status code for return nil type in Ballerina to OpenAPI spec generation Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (099183d) 79.64% compared to head (0847854) 79.70%.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.8.x    #1535      +/-   ##
============================================
+ Coverage     79.64%   79.70%   +0.05%     
- Complexity     1768     1777       +9     
============================================
  Files           124      124              
  Lines         10082    10095      +13     
  Branches       1670     1673       +3     
============================================
+ Hits           8030     8046      +16     
+ Misses         1470     1464       -6     
- Partials        582      585       +3     
Files Coverage Δ
...java/io/ballerina/openapi/converter/Constants.java 73.86% <ø> (ø)
...enapi/converter/service/OpenAPIResponseMapper.java 83.68% <100.00%> (+0.28%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lnash94 lnash94 marked this pull request as ready for review October 14, 2023 06:10
@lnash94 lnash94 force-pushed the master-1491 branch 2 times, most recently from 9a810d5 to 2224d4a Compare October 15, 2023 17:00
@ballerina-platform ballerina-platform deleted a comment from github-actions bot Oct 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@dilanSachi dilanSachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnash94 lnash94 merged commit 3be01ed into ballerina-platform:1.8.x Oct 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants