Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue with Azure OpenAI Chat and OpenAI Chat connector when getting nullable values #833

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

nadheesh
Copy link
Contributor

@nadheesh nadheesh commented Feb 2, 2024

Description

Fixes https://github.com/wso2-enterprise/choreo/issues/26615

Also we are removing deprecated tags from few records in openai.chat connector because, we are using that connector to release ai.agent module that deprecated tags can fail the release of that module.
(and migrating ai.agent module to updated API will require significant effort, which we will do in the future)

Fixes # (issue)
https://github.com/wso2-enterprise/choreo/issues/26615

One line release note:

  • One line describing the feature/improvement/fix made by this PR

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested manually

Test Configuration:

  • Ballerina Version: 2201.8.4
  • Operating System: Mac

Checklist:

Changes to OpenAPI definition

  • Modified info section of the OpenAPI definition file - Example

    • description - what the connector is about
    • x-ballerina-init-description OpenAPI extension - connector initialization details
    • x-ballerina-display OpenAPI extension - connector name and path to the connector icon
  • Added proper description each API Key, if API Key authentication is defined in OpenAPI definition file

Changes to connector module

  • Added license header at the top of each .bal file.
  • Added Package.md as per the guide here
  • Added Module.md for the module of the connector as per the guide here
  • Added connector icon to the root of the connector. Icon needs to be a png of 200x200 px size with name icon.png
  • Added Ballerina.toml file with following information. For keywords refer to guide

Verifying connector module

  • Compiled the connector successfully with the targeted ballerina version.
  • Conducted smoke tests on the connector (Recommended when OpenAPI definition is obtain from an unofficial source)

Security checks

@nadheesh nadheesh requested a review from abeykoon as a code owner February 2, 2024 10:41
@lnash94 lnash94 merged commit 452afe8 into ballerina-platform:main Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants