Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for global variables in nback.llvm #127

Closed
heshanpadmasiri opened this issue Jun 24, 2021 · 4 comments · Fixed by #128
Closed

Add support for global variables in nback.llvm #127

heshanpadmasiri opened this issue Jun 24, 2021 · 4 comments · Fixed by #128
Assignees
@heshanpadmasiri
Milestone
Subset 2

Comments

@heshanpadmasiri
Copy link
Member

heshanpadmasiri commented Jun 24, 2021 •
edited by jclark
Loading

This is to support #91.

@jclark for this I am thinking of adding a new function getOrInsertGlobal(string name, Type ty) returns Value similar to getOrInsertGlobal in C api
@jclark
Copy link
Contributor

jclark commented Jun 24, 2021 •
edited
Loading

@heshanpadmasiri The link you gave is the C++ API. What is the C API?

@heshanpadmasiri
Copy link
Member Author

C API
Add global variable: LLVMAddGlobal
Get global variable:LLVMGetNamedGlobal

@jclark
Copy link
Contributor

jclark commented Jun 24, 2021

I think we should follow the C API and add methods to Module corresponding to those two functions.

Be careful about types: I believe if you add a global x of type i8, then @x is of type i8*. Please test with LLVM.

@heshanpadmasiri heshanpadmasiri mentioned this issue Jun 25, 2021
Merged
jclark pushed a commit that referenced this issue Jun 25, 2021
@heshanpadmasiri
Add support for global variables in nback.llvm (#128)
c5bbb87 
Fixes #127
@jclark jclark reopened this Jun 25, 2021
@jclark
Copy link
Contributor

jclark commented Jun 25, 2021

@heshanpadmasiri You shouldn't rely on iteration order over a map. I fixed this. I also cleaned up getIntrinsicDeclaration and tweaked a few other things. Please try to follow my style. 2b3629c

@jclark jclark closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heshanpadmasiri heshanpadmasiri

Labels
None yet
Projects
None yet
Milestone
Subset 2
Development

Successfully merging a pull request may close this issue.

Add support for global variables in nback.llvm heshanpadmasiri/nballerina
2 participants
@jclark @heshanpadmasiri