Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GraalVM check & update templates #213

Merged
merged 8 commits into from
Dec 11, 2023

Conversation

RDPerera
Copy link
Member

@RDPerera RDPerera commented Dec 6, 2023

Description

Since the Twilio connector is pure Ballerina, it has GraalVM compatibility by default, therefore daily GraalVM check removed. with that following modifications were done.

  1. Update the PR template
  2. Remove the issue_template.md
  3. Remove GraalVM scheduled checks

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

ayeshLK
ayeshLK previously approved these changes Dec 6, 2023
README.md Outdated
@@ -3,7 +3,6 @@
[![Build](https://github.com/ballerina-platform/module-ballerinax-twilio/actions/workflows/ci.yml/badge.svg)](https://github.com/ballerina-platform/module-ballerinax-twilio/actions/workflows/ci.yml)
[![Trivy](https://github.com/ballerina-platform/module-ballerinax-twilio/actions/workflows/trivy-scan.yml/badge.svg)](https://github.com/ballerina-platform/module-ballerinax-twilio/actions/workflows/trivy-scan.yml)
[![codecov](https://codecov.io/gh/ballerina-platform/module-ballerinax-twilio/branch/master/graph/badge.svg)](https://codecov.io/gh/ballerina-platform/module-ballerinax-twilio)
[![GraalVM Check](https://github.com/ballerina-platform/module-ballerinax-twilio/actions/workflows/build-with-bal-test-native.yml/badge.svg)](https://github.com/ballerina-platform/module-ballerinax-twilio/actions/workflows/build-with-bal-test-native.yml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need to remove the compatibility badge, as we still have the on-demand workflow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. changed with 5110ab.

@NipunaRanasinghe NipunaRanasinghe merged commit 4afd7f1 into ballerina-platform:master Dec 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants