Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp the twilio connector #209

Merged
merged 30 commits into from
Nov 30, 2023
Merged

Revamp the twilio connector #209

merged 30 commits into from
Nov 30, 2023

Conversation

RDPerera
Copy link
Member

@RDPerera RDPerera commented Nov 8, 2023 •
edited
Loading

Description

Revamp the connector using Open API Specification.

Fixes ballerina-platform/ballerina-library#4950 , ballerina-platform/ballerina-library#4948 , ballerina-platform/ballerina-library#4947 , ballerina-platform/ballerina-library#4920 , ballerina-platform/ballerina-library#5089 , ballerina-platform/ballerina-library#5090 , ballerina-platform/ballerina-library#5740 , ballerina-platform/ballerina-library#5750

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@RDPerera RDPerera changed the title Initial revamp Revamp the connector Nov 8, 2023
@RDPerera RDPerera marked this pull request as ready for review November 16, 2023 04:39
@RDPerera RDPerera changed the title Revamp the connector Revamp the twilio connector Nov 16, 2023
NipunaRanasinghe
NipunaRanasinghe requested changes Nov 22, 2023
View reviewed changes
LICENSE Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ballerina/Package.md Outdated Show resolved Hide resolved
docs/spec/wrapper.md Outdated Show resolved Hide resolved
docs/spec/wrapper.md Outdated Show resolved Hide resolved
NipunaRanasinghe
NipunaRanasinghe reviewed Nov 22, 2023
View reviewed changes
examples/accounts/create_sub_account.bal Outdated Show resolved Hide resolved
examples/accounts/create_sub_account.bal Outdated Show resolved Hide resolved
examples/accounts/fetch_account.bal Outdated Show resolved Hide resolved
examples/build.sh Outdated Show resolved Hide resolved
examples/calls/delete_call_log.bal Outdated Show resolved Hide resolved
examples/calls/list_call_logs.bal Outdated Show resolved Hide resolved
examples/messages/send_sms.bal Outdated Show resolved Hide resolved
examples/messages/send_whatsapp_message.bal Outdated Show resolved Hide resolved
examples/queues/create_queue.bal Outdated Show resolved Hide resolved
examples/queues/delete_queue.bal Outdated Show resolved Hide resolved
NipunaRanasinghe
NipunaRanasinghe requested changes Nov 27, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ballerina/modules/oas/client.bal Show resolved Hide resolved
examples/queues/delete_queue.bal Outdated Show resolved Hide resolved
examples/queues/fetch_queue.bal Outdated Show resolved Hide resolved
AzeemMuzammil
AzeemMuzammil reviewed Nov 29, 2023
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/trivy-scan.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
ballerina/build.gradle Outdated Show resolved Hide resolved
AzeemMuzammil
AzeemMuzammil approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@AzeemMuzammil AzeemMuzammil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NipunaRanasinghe NipunaRanasinghe merged commit f7b8f4d into ballerina-platform:master Nov 30, 2023
1 check passed
This was referenced Nov 30, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzeemMuzammil AzeemMuzammil AzeemMuzammil approved these changes

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe approved these changes

@indikasampath2000 indikasampath2000 Awaiting requested review from indikasampath2000

@abeykoon abeykoon Awaiting requested review from abeykoon

@SanduDS SanduDS Awaiting requested review from SanduDS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic]: Revamp Twilio Connector
3 participants
@RDPerera @NipunaRanasinghe @AzeemMuzammil