Improve error message for client configuration failures #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve error message for client configuration failures
RDPerera
requested review from
aashikam,
niveathika and
sahanHe
as code owners
RDPerera
requested review from
TharmiganK,
Thevakumar-Luheerathan,
NipunaRanasinghe and
daneshk
There was a problem hiding this comment.
@RDPerera Shall we add negative test(s) to cover these client init error scenarios?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2201.8.x #373 +/- ##
============================================
+ Coverage 74.03% 74.11% +0.08%
============================================
Files 14 14
Lines 1186 1182 -4
Branches 713 709 -4
============================================
- Hits 878 876 -2
+ Misses 308 306 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
NipunaRanasinghe
approved these changes
Nov 21, 2024
daneshk
reviewed
Nov 21, 2024
Comment on lines
+49
to
+51
| httpHandlerResult = new http:ClientOAuth2Handler(auth); | ||
| } else { | ||
| return error(INVALID_CLIENT_CONFIG); | ||
| httpHandlerResult = new http:ClientBearerTokenAuthHandler(auth); |
There was a problem hiding this comment.
In ClientOAuth2Provider initialization, we panic[1]. So, we need to trap the error.
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: wso2-enterprise/internal-support-ballerina#838