Re-organize modules in ballerinax/salesforce package #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niveathika
reviewed
Jul 17, 2024
Open
14 tasks
niveathika
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
ayeshLK
reviewed
Jul 22, 2024
|
@ayeshLK and all Just FYI before you guys review all the code. This is just moving around existing code. We need to move everything for update 10 as this a minor bump. We have used the same client in the default package. . Tests are also the existing tests, which are just being moved from default package to modules.We have no intention in improving the existing code quality in this effort, this will just be a move. All the errors and improvements required are known and tracked here ballerina-platform/ballerina-library#6697 and I will take a look at all this at once in a separate PR, as there is a lot. Please keep reviewing I will add some of the changes to this issue. |
niveathika
previously approved these changes
Jul 25, 2024
niveathika
approved these changes
Jul 25, 2024
RDPerera
reviewed
Jul 25, 2024
|
|
||
| <img src=https://raw.githubusercontent.com/ballerina-platform/module-ballerinax-sfdc/master/docs/setup/resources/create-connected-apps.png alt="Create Connected Apps" width="50%" style="border:1px solid #000000"> | ||
|
|
||
| - Here we will be using https://test.salesforce.com as we are using sandbox environment. Users can use https://login.salesforce.com for normal usage. |
There was a problem hiding this comment.
Suggested change
| - Here we will be using https://test.salesforce.com as we are using sandbox environment. Users can use https://login.salesforce.com for normal usage. | |
| - Here we will be using https://test.salesforce.com as we are using a sandbox environment. Users can use https://login.salesforce.com for normal usage. |
|
|
||
| <img src=https://raw.githubusercontent.com/ballerina-platform/module-ballerinax-sfdc/master/docs/setup/resources/create_connected%20_app.png alt="Create Connected Apps" width="100%" style="border:1px solid #000000"> | ||
|
|
||
| 4. After the creation user can get consumer key and secret through clicking on the `Manage Consumer Details` button. |
There was a problem hiding this comment.
Suggested change
| 4. After the creation user can get consumer key and secret through clicking on the `Manage Consumer Details` button. | |
| 4. After the creation, the user can get the consumer key and secret by clicking on the `Manage Consumer Details` button. |
| - Allow access if an alert pops up, and the browser will be redirected to a URL like the following: | ||
| `https://login.salesforce.com/?code=<ENCODED_CODE>` | ||
|
|
||
| - The code can be obtained after decoding the encoded code |
There was a problem hiding this comment.
Suggested change
| - The code can be obtained after decoding the encoded code | |
| - The code can be obtained after decoding the encoded code. |
| } | ||
| ``` | ||
|
|
||
| 2. Use `bal run` command to compile and run the Ballerina program. |
There was a problem hiding this comment.
Suggested change
| 2. Use `bal run` command to compile and run the Ballerina program. | |
| 2. Use the `bal run` command to compile and run the Ballerina program. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: The improvements required are known and are tracked here: ballerina-platform/ballerina-library#6697 and will be a future enhancement.
Note: A minor version bump.
Fixes: ballerina-platform/ballerina-library#6691
Modules