Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pagination #349

Merged
merged 12 commits into from
Jun 7, 2024
Merged

Add support for pagination #349

merged 12 commits into from
Jun 7, 2024

Conversation

aashikam
Copy link
Contributor

@aashikam aashikam commented Jun 3, 2024

Description

fixes: ballerina-platform/ballerina-library#6577
fixes: ballerina-platform/ballerina-library#6548

  • Test for maxRecords less than the number of records
  • Test for maxRecords more than the number of records
  • Add a changelog
  • Doc changes

ballerina/client.bal Outdated Show resolved Hide resolved
ballerina/client.bal Outdated Show resolved Hide resolved
ballerina/client.bal Show resolved Hide resolved
ballerina/client.bal Outdated Show resolved Hide resolved
aashikam and others added 2 commits June 4, 2024 20:01
@aashikam aashikam marked this pull request as ready for review June 4, 2024 17:04
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (637c2e9) to head (6e6de34).
Report is 32 commits behind head on master.

Current head 6e6de34 differs from pull request most recent head 1f58aa8

Please upload reports for the commit 1f58aa8 to get more accurate results.

Files Patch % Lines
ballerina/client.bal 80.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   74.10%   74.62%   +0.51%     
==========================================
  Files          14       14              
  Lines        1170     1186      +16     
  Branches      702      713      +11     
==========================================
+ Hits          867      885      +18     
+ Misses        303      301       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ballerina/client.bal Outdated Show resolved Hide resolved
ballerina/client.bal Show resolved Hide resolved
ballerina/tests/bulk_csv_query.bal Show resolved Hide resolved
ballerina/tests/bulk_csv_query.bal Outdated Show resolved Hide resolved
ballerina/tests/bulk_csv_query.bal Outdated Show resolved Hide resolved
@aashikam aashikam requested a review from NipunaRanasinghe June 7, 2024 01:10
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aashikam aashikam merged commit 7cebf5d into master Jun 7, 2024
2 checks passed
@aashikam aashikam deleted the csverror branch June 8, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Salesforce client] Support for pagination/chunking Issues in salesforce connector documentation
2 participants