Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spread-field error in connection pool config #712

Merged

Conversation

kalaiyarasiganeshalingam
Copy link
Contributor

@kalaiyarasiganeshalingam kalaiyarasiganeshalingam commented Jun 16, 2023

Purpose

$Subject

Fixes: ballerina-platform/ballerina-library#4594

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 74.07% and project coverage change: +0.15 🎉

Comparison is base (3f44efd) 80.36% compared to head (df7b952) 80.51%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #712      +/-   ##
============================================
+ Coverage     80.36%   80.51%   +0.15%     
- Complexity      238      258      +20     
============================================
  Files            23       23              
  Lines           876      965      +89     
  Branches        187      215      +28     
============================================
+ Hits            704      777      +73     
+ Misses           95       91       -4     
- Partials         77       97      +20     
Impacted Files Coverage Δ
...a/io/ballerina/stdlib/oracledb/compiler/Utils.java 64.33% <69.47%> (+3.04%) ⬆️
...db/compiler/analyzer/InitializerParamAnalyzer.java 85.91% <84.61%> (+19.24%) ⬆️
...lib/oracledb/compiler/analyzer/RecordAnalyzer.java 74.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kalaiyarasiganeshalingam kalaiyarasiganeshalingam merged commit c6904a1 into ballerina-platform:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add compiler plugin validation to validate spread-field config initialization
2 participants