Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spread-field error in connection pool config #948

Conversation

kalaiyarasiganeshalingam
Copy link
Contributor

@kalaiyarasiganeshalingam kalaiyarasiganeshalingam commented Jun 13, 2023

Purpose

$Subject

Fixes:
https://github.com/wso2-enterprise/internal-support-ballerina/issues/349
ballerina-platform/ballerina-library#4594

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 73.75% and project coverage change: -0.48 ⚠️

Comparison is base (e7f5d51) 80.75% compared to head (0eb5442) 80.27%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #948      +/-   ##
============================================
- Coverage     80.75%   80.27%   -0.48%     
- Complexity       98      123      +25     
============================================
  Files            20       20              
  Lines           478      578     +100     
  Branches         86      117      +31     
============================================
+ Hits            386      464      +78     
- Misses           59       64       +5     
- Partials         33       50      +17     
Impacted Files Coverage Δ
...java/io/ballerina/stdlib/mysql/compiler/Utils.java 67.72% <67.50%> (-9.56%) ⬇️
...ql/compiler/analyzer/InitializerParamAnalyzer.java 87.32% <92.30%> (+23.83%) ⬆️
...stdlib/mysql/compiler/analyzer/RecordAnalyzer.java 74.35% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kalaiyarasiganeshalingam kalaiyarasiganeshalingam merged commit fe4dea6 into ballerina-platform:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants