Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default username for client connections #456

Merged
merged 6 commits into from
Jun 6, 2022

Conversation

kaneeldias
Copy link
Contributor

Purpose

$subject

Related issue: ballerina-platform/ballerina-library#2397

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #456 (7eb8260) into master (a0fa761) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #456      +/-   ##
============================================
- Coverage     91.03%   90.68%   -0.36%     
+ Complexity       40       39       -1     
============================================
  Files            13       13              
  Lines           279      279              
  Branches         45       45              
============================================
- Hits            254      253       -1     
  Misses           10       10              
- Partials         15       16       +1     
Impacted Files Coverage Δ
ballerina/client.bal 97.14% <100.00%> (ø)
...erina/stdlib/mysql/nativeimpl/ClientProcessor.java 87.09% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbd309...7eb8260. Read the comment docs.

@kaneeldias kaneeldias marked this pull request as ready for review April 26, 2022 03:38
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaneeldias kaneeldias merged commit 04b8ba0 into ballerina-platform:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants