Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
AzeemMuzammil committed Feb 19, 2024
1 parent 0ac36f4 commit f06004d
Show file tree
Hide file tree
Showing 13 changed files with 35 additions and 69 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-with-bal-test-graalvm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ jobs:
uses: ballerina-platform/ballerina-standard-library/.github/workflows/build-with-bal-test-graalvm-connector-template.yml@main
secrets: inherit
with:
additional-build-flags: "-x :candid-examples:build -Pgroups=mock"
additional-build-flags: "-x :candid-examples:build -Pgroups=mock"
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

[![Build](https://github.com/ballerina-platform/module-ballerinax-candid/actions/workflows/ci.yml/badge.svg)](https://github.com/ballerina-platform/module-ballerinax-candid/actions/workflows/ci.yml)
[![Trivy](https://github.com/ballerina-platform/module-ballerinax-candid/actions/workflows/trivy-scan.yml/badge.svg)](https://github.com/ballerina-platform/module-ballerinax-candid/actions/workflows/trivy-scan.yml)
[![codecov](https://codecov.io/gh/ballerina-platform/module-ballerinax-candid/branch/master/graph/badge.svg)](https://codecov.io/gh/ballerina-platform/module-ballerinax-candid)
[![GraalVM Check](https://github.com/ballerina-platform/module-ballerinax-candid/actions/workflows/build-with-bal-test-graalvm.yml/badge.svg)](https://github.com/ballerina-platform/module-ballerinax-candid/actions/workflows/build-with-bal-test-graalvm.yml)
[![GitHub Last Commit](https://img.shields.io/github/last-commit/ballerina-platform/module-ballerinax-candid.svg)](https://github.com/ballerina-platform/module-ballerinax-candid/commits/master)
[![GitHub Issues](https://img.shields.io/github/issues/ballerina-platform/ballerina-library/module/candid.svg?label=Open%20Issues)](https://github.com/ballerina-platform/ballerina-library/labels/module%2Fcandid)
Expand All @@ -20,14 +19,14 @@ Currently, the following Candid APIs are supported through this module
- **Premier API**
- The Premier API is a more comprehensive API that provides access to a wider range of nonprofit data, including financial information, staffing data, grantmaking data, and DEI data. It is ideal for applications that need to deep dive into the data of individual nonprofits or perform complex analyses of nonprofit data.

## Setup Guide
## Setup guide
To use the Candid.org Connector in Ballerina, you must first obtain an API key from Candid.org.

### Step 1: Visit Candid's Developer API Access page
### Step 1: Visit Candid's developer API access page
1. Visit [Candid's Developer API Access](https://developer.candid.org/reference/getting-access) page.
2. Review the documentation to understand the type of access suits your need.

### Step 2: Request API Access
### Step 2: Request API access
- **For a Trial Account:** If you're looking for trial access to explore Candid's API, complete the [form](https://info.candid.org/API-free-trial) to request trial access. Candid.org will review your request and get in touch with you regarding your trial API key.

<img src=https://raw.githubusercontent.com/ballerina-platform/module-ballerinax-candid/master/docs/setup/resources/1-trial-account-form.png alt="Candid API Access Form" width="50%">
Expand Down
6 changes: 3 additions & 3 deletions ballerina/Module.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ Currently, the following Candid APIs are supported through this module
- **Premier API**
- The Premier API is a more comprehensive API that provides access to a wider range of nonprofit data, including financial information, staffing data, grantmaking data, and DEI data. It is ideal for applications that need to deep dive into the data of individual nonprofits or perform complex analyses of nonprofit data.

## Setup Guide
## Setup guide
To use the Candid.org Connector in Ballerina, you must first obtain an API key from Candid.org.

### Step 1: Visit Candid's Developer API Access page
### Step 1: Visit Candid's developer API access page
1. Visit [Candid's Developer API Access](https://developer.candid.org/reference/getting-access) page.
2. Review the documentation to understand the type of access suits your need.

### Step 2: Request API Access
### Step 2: Request API access
- **For a Trial Account:** If you're looking for trial access to explore Candid's API, complete the [form](https://info.candid.org/API-free-trial) to request trial access. Candid.org will review your request and get in touch with you regarding your trial API key.

<img src=https://raw.githubusercontent.com/ballerina-platform/module-ballerinax-candid/master/docs/setup/resources/1-trial-account-form.png alt="Candid API Access Form" width="50%">
Expand Down
6 changes: 3 additions & 3 deletions ballerina/Package.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ Currently, the following Candid APIs are supported through this module
- **Premier API**
- The Premier API is a more comprehensive API that provides access to a wider range of nonprofit data, including financial information, staffing data, grantmaking data, and DEI data. It is ideal for applications that need to deep dive into the data of individual nonprofits or perform complex analyses of nonprofit data.

## Setup Guide
## Setup guide
To use the Candid.org Connector in Ballerina, you must first obtain an API key from Candid.org.

### Step 1: Visit Candid's Developer API Access page
### Step 1: Visit Candid's developer API access page
1. Visit [Candid's Developer API Access](https://developer.candid.org/reference/getting-access) page.
2. Review the documentation to understand the type of access suits your need.

### Step 2: Request API Access
### Step 2: Request API access
- **For a Trial Account:** If you're looking for trial access to explore Candid's API, complete the [form](https://info.candid.org/API-free-trial) to request trial access. Candid.org will review your request and get in touch with you regarding your trial API key.

<img src=https://raw.githubusercontent.com/ballerina-platform/module-ballerinax-candid/master/docs/setup/resources/1-trial-account-form.png alt="Candid API Access Form" width="50%">
Expand Down
3 changes: 3 additions & 0 deletions ballerina/modules/essentials/client.bal
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// AUTO-GENERATED FILE. DO NOT MODIFY.
// This file is auto-generated by the Ballerina OpenAPI tool.

// Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org).
//
// WSO2 LLC. licenses this file to you under the Apache License,
Expand Down
3 changes: 3 additions & 0 deletions ballerina/modules/essentials/types.bal
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// AUTO-GENERATED FILE. DO NOT MODIFY.
// This file is auto-generated by the Ballerina OpenAPI tool.

// Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org).
//
// WSO2 LLC. licenses this file to you under the Apache License,
Expand Down
3 changes: 3 additions & 0 deletions ballerina/modules/essentials/utils.bal
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// AUTO-GENERATED FILE. DO NOT MODIFY.
// This file is auto-generated by the Ballerina OpenAPI tool.

// Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org).
//
// WSO2 LLC. licenses this file to you under the Apache License,
Expand Down
3 changes: 3 additions & 0 deletions ballerina/modules/premier/client.bal
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// AUTO-GENERATED FILE. DO NOT MODIFY.
// This file is auto-generated by the Ballerina OpenAPI tool.

// Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org).
//
// WSO2 LLC. licenses this file to you under the Apache License,
Expand Down
3 changes: 3 additions & 0 deletions ballerina/modules/premier/types.bal
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// AUTO-GENERATED FILE. DO NOT MODIFY.
// This file is auto-generated by the Ballerina OpenAPI tool.

// Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org).
//
// WSO2 LLC. licenses this file to you under the Apache License,
Expand Down
3 changes: 3 additions & 0 deletions ballerina/modules/premier/utils.bal
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// AUTO-GENERATED FILE. DO NOT MODIFY.
// This file is auto-generated by the Ballerina OpenAPI tool.

// Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org).
//
// WSO2 LLC. licenses this file to you under the Apache License,
Expand Down
8 changes: 7 additions & 1 deletion docs/spec/sanitations.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Introduction
# Sanitations: Ballerina Candid Connector

_Authors_: @AzeemMuzammil \
_Reviewers_: @NipunaRanasinghe \
_Created_: 2024/02/19 \
_Updated_: 2024/02/19 \
_Edition_: Swan Lake

This file documents the modifications applied to enhance the usability of the official OpenAPI Specification (OAS). These adjustments are made to address known limitations on the language side and improve overall functionality.
18 changes: 0 additions & 18 deletions issue_template.md

This file was deleted.

39 changes: 0 additions & 39 deletions pull_request_template.md

This file was deleted.

0 comments on commit f06004d

Please sign in to comment.