Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testcase for the ref cursor fix #20

Merged
merged 7 commits into from
Mar 16, 2024

Conversation

aashikam
Copy link
Contributor

@aashikam aashikam commented Mar 15, 2024

Purpose

Related: https://github.com/wso2-enterprise/internal-support-ballerina/issues/623

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (409d060) to head (5b9a116).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #20   +/-   ##
=========================================
  Coverage     82.69%   82.69%           
  Complexity       11       11           
=========================================
  Files             6        6           
  Lines           104      104           
  Branches         22       22           
=========================================
  Hits             86       86           
  Misses           10       10           
  Partials          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashikam
Copy link
Contributor Author

I have tested this with my redshift clusters and the issue is fixed. Mentioning this here since the test server is a postgres server and somehow gets an error with the PROCEDUREsyntax when creating the stored procedure in the before suite setup, therefore I have used FUNCTION instead for tests. PROCEDURE works in actual redshift cluster.

@aashikam aashikam changed the title Bump sql version Add testcase for the ref cursor fix Mar 16, 2024
@aashikam aashikam merged commit aca9b8c into ballerina-platform:main Mar 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants