Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate client with nilable types #9

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

NipunaRanasinghe
Copy link
Contributor

Purpose

This PR uses the --nullable option when generating the client using the Ballerina OpenAPI tool.

  • The Asana OpenAPI specification has not properly included the "nullable" property for some request and response schemas.
  • Therefore, the --nullable option is used as a precaution to avoid potential data-binding issues in the runtime, which will generate all the request/response type fields with the support to handle null values.
  • This workaround can be removed once Handle un-defined nillable properties  ballerina-library#4870 is addressed.

Related to ballerina-platform/ballerina-library#6238

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

Copy link
Member

@ayeshLK ayeshLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NipunaRanasinghe NipunaRanasinghe merged commit 7fe6bf4 into ballerina-platform:main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants