Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the integration test suite for the readString API #43

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

nipunayf
Copy link
Contributor

@nipunayf nipunayf commented Mar 8, 2024

Purpose

As a measure to increase the reliability of the readString API, the integration test suite has been used to ensure the robustness of this API. The PR addresses the following points:

  1. The API implementations are refactored to follow a uniform path, making the code more readable.
  2. The lexer is modified to support the newline character in Windows.

Fixes ballerina-platform/ballerina-library#6141
Fixes ballerina-platform/ballerina-library#4330
Fixes ballerina-platform/ballerina-library#4325

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@nipunayf nipunayf changed the title Added the integration test suite for the readString API Add the integration test suite for the readString API Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (cd505a8) to head (e10169d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   99.13%   99.72%   +0.59%     
==========================================
  Files          44       44              
  Lines        2185     2170      -15     
  Branches     1365     1357       -8     
==========================================
- Hits         2166     2164       -2     
+ Misses         19        6      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NipunaRanasinghe NipunaRanasinghe merged commit a8e56ed into ballerina-platform:main Mar 12, 2024
7 checks passed
warunalakshitha pushed a commit to warunalakshitha/module-ballerina-yaml that referenced this pull request Nov 13, 2024
…te-lang-version

Update lang and dependency versions for Update 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants