Fix invalid writing of special characters when writing to a YAML file #37
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 94.09% 94.20% +0.11%
==========================================
Files 44 44
Lines 2169 2176 +7
Branches 1356 1360 +4
==========================================
+ Hits 2041 2050 +9
+ Misses 128 126 -2 ☔ View full report in Codecov by Sentry. |
nipunayf
requested review from
NipunaRanasinghe,
KavinduZoysa,
LakshanWeerasinghe and
mindula
| ? string `${state.delimiter}${value}${state.delimiter}` : value, | ||
| tag | ||
| }); | ||
| if value.includes("\n") { |
There was a problem hiding this comment.
| if value.includes("\n") { | |
| if value.includes("\n" || value.includes("\r\n") { |
There was a problem hiding this comment.
Supporting OS-specific new lines is tracked with another issue: ballerina-platform/ballerina-library#4330.
| common:Event[] events = check getSerializedEvents(line); | ||
| int index = 0; | ||
| foreach common:Event event in events { | ||
| if event is common:ScalarEvent { |
There was a problem hiding this comment.
We need to add a assertFail scenario for the else condition
There was a problem hiding this comment.
The test is designed to consider only the ScalarEvents and ignore the rest, as the new lines are only processed in these events. Hence, the events that are not ScalarEvents form a valid stream for the given input.
NipunaRanasinghe
merged commit 1e1a818
into
ballerina-platform:main
Update ballerina gradle plugin version
Purpose
The current implementation of the serializer to switch between plain-style and quoted strings is incomplete for some characters. Hence, the serializer is modified to use the parser to determine if a string can be written in plain-style.
Fixes #6031
Examples
The newline symbol is added in double-quoted scalars to represent new lines in a Ballerina string. For instance, consider the following Ballerina string:
The above string is represented in YAML as follows:
"first\nsecond\nthird"Checklist