Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a more intuitive createRandomUuid() function #443

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

ImeshBalasuriya
Copy link
Contributor

@ImeshBalasuriya ImeshBalasuriya commented Oct 4, 2023

Purpose

Fixes ballerina-platform/ballerina-library#4147

Examples

string uuid = uuid:createRandomUuid();    // analogous to uuid:createType4AsString()

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@ImeshBalasuriya ImeshBalasuriya changed the title Add a more intuitive `createRandomUuid Add a more intuitive createRandomUuid function Oct 4, 2023
@ImeshBalasuriya ImeshBalasuriya changed the title Add a more intuitive createRandomUuid function Add a more intuitive createRandomUuid() function Oct 4, 2023
ballerina/uuid.bal Outdated Show resolved Hide resolved
@daneshk
Copy link
Member

daneshk commented Oct 4, 2023

@ImeshBalasuriya Can you update the changelog.md file and the spec in docs directory?

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1eb2bbc) 95.43% compared to head (041b94e) 95.47%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
+ Coverage   95.43%   95.47%   +0.03%     
==========================================
  Files           3        3              
  Lines         241      243       +2     
  Branches      109      110       +1     
==========================================
+ Hits          230      232       +2     
  Misses         11       11              
Files Coverage Δ
ballerina/uuid.bal 92.48% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daneshk
Copy link
Member

daneshk commented Oct 5, 2023

LGTM
Thanks, @ImeshBalasuriya for the contribution.

@daneshk daneshk merged commit ef2b24b into ballerina-platform:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the possibility to give a more intuitive function in UUID module
2 participants