Make Java classes proper utilities #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the design cleaner by marking Java classes as `final` and excitability declaring their default constructors as `private`. This change also the code coverage more accurate. Fixes #4894.
native/src/main/java/io/ballerina/stdlib/url/nativeimpl/Encode.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
=============================================
+ Coverage 82.85% 93.54% +10.69%
Complexity 10 10
=============================================
Files 7 6 -1
Lines 35 31 -4
Branches 9 9
=============================================
Hits 29 29
+ Misses 4 0 -4
Partials 2 2
☔ View full report in Codecov by Sentry. |
This makes it clearer that the class is a proper utility.
|
Kudos, SonarCloud Quality Gate passed!
|
ThisaruGuruge
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes ballerina-platform/ballerina-library#4894.
Examples
Checklist