Add a tcp chat server implementation example #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randilt
requested review from
ThisaruGuruge,
DimuthuMadushan,
MohamedSabthar and
shafreenAnfar
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1435 +/- ##
=========================================
Coverage 83.02% 83.02%
Complexity 215 215
=========================================
Files 22 22
Lines 813 813
Branches 81 81
=========================================
Hits 675 675
Misses 99 99
Partials 39 39 ☔ View full report in Codecov by Sentry. |
Co-authored-by: DimuthuMadushan <[email protected]>
|
@DimuthuMadushan I have added the changes you have suggested. |
ayeshLK
reviewed
Jan 9, 2025
Nuvindu
reviewed
Jan 9, 2025
ayeshLK
reviewed
Jan 9, 2025
Nuvindu
reviewed
Jan 9, 2025
Nuvindu
reviewed
Jan 9, 2025
Co-authored-by: Nuvindu Nirmana <[email protected]>
Co-authored-by: Nuvindu Nirmana <[email protected]>
…module-ballerina-tcp into tcp-chat-server-example
daneshk
reviewed
Jan 9, 2025
Co-authored-by: Thisaru Guruge <[email protected]>
Co-authored-by: Thisaru Guruge <[email protected]>
|
@ThisaruGuruge I applied the changes you suggested, thanks! |
|
ThisaruGuruge
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
LGTM. @DimuthuMadushan @Nuvindu if there are no further comments, let's merge this.
Nuvindu
approved these changes
Jan 10, 2025
DimuthuMadushan
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #2094
Examples
Checklist