Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close resources for call procedure failure #715

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

niveathika
Copy link
Contributor

@niveathika niveathika commented Jun 12, 2024

Purpose

Fixes: ballerina-platform/ballerina-library#6626

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (c7cf7b6) to head (3b9f736).

Files Patch % Lines
...ballerina/stdlib/sql/nativeimpl/CallProcessor.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #715   +/-   ##
=========================================
  Coverage     80.03%   80.03%           
  Complexity      109      109           
=========================================
  Files            42       42           
  Lines          3971     3977    +6     
  Branches        752      752           
=========================================
+ Hits           3178     3183    +5     
- Misses          537      538    +1     
  Partials        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niveathika niveathika requested a review from Bhashinee June 12, 2024 05:19
@niveathika niveathika marked this pull request as ready for review June 12, 2024 05:19
@niveathika niveathika requested a review from daneshk as a code owner June 12, 2024 05:19
@niveathika niveathika merged commit b1c955f into master Jun 12, 2024
10 of 11 checks passed
@niveathika niveathika deleted the patch branch June 12, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources are not cleaned properly for call procedures
2 participants