Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport revert backtick support to v1.10.x #692

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

niveathika
Copy link
Contributor

Purpose

$subject as the original fix is incomplete and need to be revisited

Part of ballerina-platform/ballerina-library#4925

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

…port-backtick"

This reverts commit b9cf5c0, reversing
changes made to 49d0d48.

(cherry picked from commit 0854523)
@niveathika niveathika requested a review from daneshk as a code owner October 15, 2023 10:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5611fac) 80.02% compared to head (c52acc2) 80.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             v1.10.x     #692      +/-   ##
=============================================
- Coverage      80.02%   80.00%   -0.03%     
  Complexity       107      107              
=============================================
  Files             46       45       -1     
  Lines           3975     3965      -10     
  Branches         749      751       +2     
=============================================
- Hits            3181     3172       -9     
  Misses           535      535              
+ Partials         259      258       -1     
Files Coverage Δ
...c/main/java/io/ballerina/stdlib/sql/Constants.java 100.00% <ø> (ø)
...ballerina/stdlib/sql/nativeimpl/CallProcessor.java 72.88% <100.00%> (+0.12%) ⬆️
...lerina/stdlib/sql/nativeimpl/ExecuteProcessor.java 81.34% <100.00%> (ø)
...allerina/stdlib/sql/nativeimpl/QueryProcessor.java 81.89% <100.00%> (-0.31%) ⬇️
...processor/AbstractStatementParameterProcessor.java 81.81% <100.00%> (+0.07%) ⬆️
...main/java/io/ballerina/stdlib/sql/utils/Utils.java 77.98% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niveathika niveathika merged commit c8ead54 into ballerina-platform:v1.10.x Oct 16, 2023
5 checks passed
@niveathika niveathika deleted the v1.10.x branch October 16, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants