Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action not set in the 'content-type' header in SOAP 1.2 #116

Merged
merged 11 commits into from
Dec 6, 2023

Conversation

Nuvindu
Copy link
Contributor

@Nuvindu Nuvindu commented Nov 30, 2023

Purpose

Fixes: #5842

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ec5883) 96.33% compared to head (f1b2957) 96.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   96.33%   96.38%   +0.05%     
==========================================
  Files          12       12              
  Lines         409      415       +6     
  Branches      283      288       +5     
==========================================
+ Hits          394      400       +6     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ballerina/soap_utils.bal Outdated Show resolved Hide resolved
@Nuvindu Nuvindu changed the title Fix soapAction not set in the 'content-type' header in SOAP 1.2 Fix action not set in the 'content-type' header in SOAP 1.2 Dec 1, 2023
@ThisaruGuruge
Copy link
Member

Since this is a backword-incompatible change, let's update the version to next minor version.

Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThisaruGuruge ThisaruGuruge merged commit f742d38 into ballerina-platform:master Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOAP action not set in content-type header with ballerina/soap.soap12:0.9.0
4 participants