Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some Java classes proper utilities #111

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Oct 23, 2023

Purpose

Closes ballerina-platform/ballerina-library#5075.

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

vil02 added 2 commits October 23, 2023 17:17
Made the design cleaner by marking Java classes as `final`
and explicitly declaring their default constructors as `private`.
This change makes the code coverage reports more accurate.
Closes #5075.
@vil02 vil02 requested a review from shafreenAnfar as a code owner October 23, 2023 15:19
dilanSachi
dilanSachi previously approved these changes Nov 1, 2023
@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb38b51) 96.33% compared to head (e56e65e) 96.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          12       12           
  Lines         409      409           
  Branches      283      283           
=======================================
  Hits          394      394           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThisaruGuruge ThisaruGuruge removed the Skip GraalVM Check This will skip the GraalVM compatibility check label Nov 3, 2023
@ThisaruGuruge ThisaruGuruge merged commit d8daae1 into ballerina-platform:master Nov 3, 2023
8 checks passed
@vil02 vil02 deleted the 5075_make_some_java_classes_proper_utilities branch November 3, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some of the Java classes in module-soap proper utility classes
4 participants