Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do validation for old persist toml configs #275

Merged

Conversation

Bhashinee
Copy link
Member

@Bhashinee Bhashinee commented Mar 6, 2024

Purpose

Fixes:ballerina-platform/ballerina-library#6144

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@Bhashinee Bhashinee force-pushed the revert-271-revert-268-main branch from 166f1e4 to aae9e2f Compare March 6, 2024 06:02
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.15%. Comparing base (561b857) to head (d9c2668).

Files Patch % Lines
...ballerina/stdlib/persist/compiler/utils/Utils.java 75.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #275      +/-   ##
============================================
+ Coverage     87.09%   88.15%   +1.06%     
- Complexity      346      351       +5     
============================================
  Files            30       30              
  Lines          1147     1140       -7     
  Branches        141      140       -1     
============================================
+ Hits            999     1005       +6     
+ Misses           94       85       -9     
+ Partials         54       50       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,27 @@
// Copyright (c) 2024 WSO2 LLC. (http://www.wso2.org) All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright (c) 2024 WSO2 LLC. (http://www.wso2.org) All Rights Reserved.
// Copyright (c) 2024 WSO2 LLC. (http://www.wso2.org).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in
d9c2668

daneshk
daneshk previously approved these changes Mar 11, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Bhashinee Bhashinee merged commit f31520a into ballerina-platform:main Mar 11, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants