-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compiler validations for custom foreign key fields #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
============================================
- Coverage 88.49% 87.09% -1.41%
- Complexity 343 346 +3
============================================
Files 30 30
Lines 1113 1147 +34
Branches 135 141 +6
============================================
+ Hits 985 999 +14
- Misses 76 94 +18
- Partials 52 54 +2 ☔ View full report in Codecov by Sentry. |
hasathcharu
force-pushed
the
new-fixes-wip
branch
from
March 1, 2024 11:00
80699a7
to
c19144a
Compare
hasathcharu
force-pushed
the
new-fixes-wip
branch
from
March 1, 2024 11:11
c19144a
to
b8fe67b
Compare
daneshk
reviewed
Mar 5, 2024
compiler-plugin/src/main/java/io/ballerina/stdlib/persist/compiler/DiagnosticsCodes.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
compiler-plugin/src/main/java/io/ballerina/stdlib/persist/compiler/utils/Utils.java
Outdated
Show resolved
Hide resolved
Bhashinee
previously approved these changes
Mar 8, 2024
daneshk
previously approved these changes
Mar 10, 2024
Quality Gate passedIssues Measures |
hasathcharu
changed the title
Compiler validations and diagnostics for newly added advanced annotations
Add compiler validations for custom foreign key fields
Mar 11, 2024
daneshk
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To support the newly added
sql:Relation
annotation to allow definition of custom foreign keys.Fixes: ballerina-platform/ballerina-library/issues/6068
Checklist