Make some Java classes proper utilities #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Closes #5051.
|
Kudos, SonarCloud Quality Gate passed!
|
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
@daneshk please approve the workflows |
|
Thanks @vil02 for the contribution. Sorry for the delay in responding. PR LGTM |
daneshk
approved these changes
Nov 2, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
============================================
+ Coverage 91.33% 92.06% +0.72%
Complexity 25 25
============================================
Files 16 16
Lines 127 126 -1
Branches 32 32
============================================
Hits 116 116
+ Misses 10 9 -1
Partials 1 1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes ballerina-platform/ballerina-library#5051.
Examples
Checklist