Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jakarta.activation to jakarta.activation-api #517

Merged
merged 5 commits into from
Sep 8, 2023

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Sep 8, 2023

Purpose

$Subject

Fixes: ballerina-platform/ballerina-library#4789

Check the dependant module builds here: https://github.com/ballerina-platform/module-ballerina-mime/actions/runs/6119890254/job/16610695157

Examples

import ballerina/mime as _;
import ballerina/email as _;
import ballerina/io;

public function main() {
    io:println("Hello, World!");
}

Before the fix:

$ bal build

Compiling source
        wso2/sample:0.1.0

Generating executable
        warning: Detected conflicting jar files:
                'activation-1.1.1.jar' dependency of 'ballerina/email' conflict with 'jakarta.activation-2.0.1.jar' dependency of 'ballerina/mime'
        target/bin/sample.jar

After the fix:

Compiling source
        wso2/sample:0.1.0

Generating executable
        target/bin/sample.jar

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@TharmiganK TharmiganK changed the title Change jakarta.activation to jakarta-activation-api Change jakarta.activation to jakarta.activation-api Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ddf5052) 81.81% compared to head (3ccd523) 81.81%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #517   +/-   ##
=========================================
  Coverage     81.81%   81.81%           
  Complexity        9        9           
=========================================
  Files            20       20           
  Lines          1160     1160           
  Branches        283      283           
=========================================
  Hits            949      949           
  Misses          129      129           
  Partials         82       82           
Files Changed Coverage Δ
.../stdlib/mime/nativeimpl/MimeDataSourceBuilder.java 88.23% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TharmiganK TharmiganK marked this pull request as ready for review September 8, 2023 09:44
@TharmiganK TharmiganK merged commit df7bead into master Sep 8, 2023
@TharmiganK TharmiganK deleted the change-jakarta-api branch September 8, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve conflicting JAR issue with mime and email
2 participants