Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace base64 URL encode/decode APIs #129

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

ldclakmal
Copy link
Member

@ldclakmal ldclakmal commented Feb 23, 2021

Purpose

This PR replaces the usages of base64 URL encode/decode APIs from ballerina/encoding module.

Fixes: ballerina-platform/ballerina-library#1212

Related to: ballerina-platform/ballerina-library#907

Related to: ballerina-platform/ballerina-library#584

@ldclakmal ldclakmal force-pushed the dev branch 3 times, most recently from 4af584a to ea6792b Compare February 23, 2021 13:12
@ldclakmal ldclakmal marked this pull request as ready for review February 23, 2021 13:19
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #129 (3605646) into master (98a55f3) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
- Coverage     70.63%   70.56%   -0.07%     
- Complexity       93       97       +4     
============================================
  Files            10       11       +1     
  Lines           538      547       +9     
  Branches        272      272              
============================================
+ Hits            380      386       +6     
- Misses          155      158       +3     
  Partials          3        3              
Impacted Files Coverage Δ Complexity Δ
.../java/org/ballerinalang/stdlib/jwt/JwksClient.java 63.49% <0.00%> (+1.95%) 10.00 <0.00> (ø)
...in/java/org/ballerinalang/stdlib/jwt/JwtUtils.java 44.44% <44.44%> (ø) 2.00 <2.00> (?)
jwt-ballerina/jwt_issuer.bal 70.52% <60.00%> (ø) 13.00 <1.00> (ø)
jwt-ballerina/jwt_validator.bal 78.00% <66.66%> (ø) 63.00 <3.00> (ø)
jwt-ballerina/jwt_commons.bal 100.00% <100.00%> (ø) 2.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a55f3...3605646. Read the comment docs.

@ldclakmal ldclakmal merged commit cc0ec74 into ballerina-platform:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace base64 URL encode/decode APIs
2 participants