-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow records as a header type and other basic types in the resource signature #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamil321
force-pushed
the
header-record
branch
from
March 16, 2022 11:17
c26ba67
to
24c8874
Compare
ballerina-tests/tests/service_dispatching_header_param_binding_test.bal
Outdated
Show resolved
Hide resolved
chamil321
force-pushed
the
header-record
branch
from
March 16, 2022 12:34
24c8874
to
7cec7e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
============================================
- Coverage 80.67% 80.63% -0.05%
Complexity 71 71
============================================
Files 347 348 +1
Lines 18674 18760 +86
Branches 4165 4183 +18
============================================
+ Hits 15066 15127 +61
- Misses 2803 2822 +19
- Partials 805 811 +6
Continue to review full report at Codecov.
|
ayeshLK
reviewed
Mar 18, 2022
chamil321
changed the title
Allow records as a header type in the resource signature
Allow records as a header type and other basic types in the resource signature
Mar 24, 2022
ayeshLK
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes ballerina-platform/ballerina-library#2699
Fixes ballerina-platform/ballerina-library#2807
Examples
Allow records as a header type
Support other basic types
Also types can be intersected with
readonly
type and be nilableChecklist