[master] Add Query Parameter Annotation Mapping for Http Service #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnash94
requested review from
TharmiganK,
daneshk and
shafreenAnfar
as code owners
lnash94
force-pushed
the
service_query_annotation
branch
from
cba7ed2 to
8f73f3e
Compare
ballerina-tests/http-dispatching-tests/tests/service_dispatching_query_param_binding_test.bal
Outdated
Show resolved
Hide resolved
|
@lnash94 do we need any updates to the tool spec along with these changes? |
native/src/main/java/io/ballerina/stdlib/http/api/service/signature/ParamHandler.java
Outdated
Show resolved
Hide resolved
These changes need to be addressed via HTTP-side spec and annotation integrating changes, which we will address via the tool specs. |
ballerina-tests/http-dispatching-tests/tests/service_dispatching_query_param_binding_test.bal
Outdated
Show resolved
Hide resolved
|
TharmiganK
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix: ballerina-platform/ballerina-library#7006
Partial fix for the main issue: ballerina-platform/ballerina-library#6747
Examples
Checklist