Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAS embedding issues #2105

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Fix OAS embedding issues #2105

merged 3 commits into from
Aug 12, 2024

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Aug 12, 2024

Purpose

$Subject

Also removed the deprecation for specifying the OpenAPI document using the service config annotation

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

@TharmiganK TharmiganK force-pushed the fix-openapi-overwrite branch from 5996e4e to 849f861 Compare August 12, 2024 07:31
@TharmiganK TharmiganK changed the title Fix OAS getting overwrite by empty array Fix OAS embedding issues Aug 12, 2024
@TharmiganK TharmiganK force-pushed the fix-openapi-overwrite branch from 163a8fe to 3b6bf30 Compare August 12, 2024 08:16
Copy link

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.23%. Comparing base (65c4764) to head (3b6bf30).
Report is 1 commits behind head on master.

Files Patch % Lines
...odemodifier/contract/ContractInfoModifierTask.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2105      +/-   ##
============================================
+ Coverage     80.22%   80.23%   +0.01%     
  Complexity      668      668              
============================================
  Files           408      408              
  Lines         22914    22914              
  Branches       5266     5266              
============================================
+ Hits          18382    18386       +4     
+ Misses         3405     3396       -9     
- Partials       1127     1132       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK merged commit 5a6fc69 into master Aug 12, 2024
7 of 8 checks passed
@TharmiganK TharmiganK deleted the fix-openapi-overwrite branch August 12, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants