New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update implementation to resolve lang spec deviation misuse #1706

Merged

dilanSachi merged 12 commits into ballerina-platform:master from dilanSachi:fix-lang-spec-deviation

Jul 12, 2023

Contributor

dilanSachi commented Jul 12, 2023 •

edited

Loading

Purpose

Related issue - ballerina-platform/ballerina-library#4584
Also fixes - ballerina-platform/ballerina-library#4649
We have moved the interceptor array creation to a separate function instead of the init function and called it from native side when setting up the interceptors.

Examples

Checklist

dilanSachi added 5 commits

July 12, 2023 10:40


          [Automated] Update the native jar versions

e4bd2a4


          [Automated] Update the native jar versions

22f5933


          Update latest lang version

fbd8442


          Update implementation to fix lang spec deviation

d0d9fa8


          Update spotbugs-exclude.xml

f6a593e

dilanSachi added the Skip GraalVM Check label

dilanSachi marked this pull request as ready for review

July 12, 2023 06:26

dilanSachi requested review from shafreenAnfar and TharmiganK as code owners

July 12, 2023 06:26

dilanSachi removed the Skip GraalVM Check label

codecov bot commented Jul 12, 2023 •

edited

Loading

Codecov Report

Patch coverage: 75.55% and project coverage change: -0.05 ⚠️

Comparison is base (f3f81d4) 81.61% compared to head (565c2d0) 81.56%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1706      +/-   ##
============================================
- Coverage     81.61%   81.56%   -0.05%     
  Complexity      577      577              
============================================
  Files           393      393              
  Lines         21395    21423      +28     
  Branches       4790     4796       +6     
============================================
+ Hits          17461    17474      +13     
- Misses         2936     2946      +10     
- Partials        998     1003       +5

Impacted Files	Coverage Δ
...in/java/io/ballerina/stdlib/http/api/HttpUtil.java	`76.45% <62.96%> (-0.43%)`	⬇️
ballerina/http_service_endpoint.bal	`88.31% <88.88%> (+0.31%)`	⬆️
ballerina/resiliency_failover_client.bal	`83.12% <100.00%> (ø)`
ballerina/resiliency_load_balance_client.bal	`82.68% <100.00%> (ø)`
...java/io/ballerina/stdlib/http/api/HttpService.java	`90.22% <100.00%> (+0.14%)`	⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dilanSachi added 6 commits

July 12, 2023 12:14


          Revert the lang version

3e60e2c


          Remove redundant newline

a64532a


          [Automated] Update the native jar versions

19a4e94


          Add a null check for interceptor values

179e919


          Update test cases

9c01a6d


          [Automated] Update the native jar versions

614477c

dilanSachi added the Skip GraalVM Check label


          Update changelog.md

565c2d0

sonarcloud bot commented Jul 12, 2023

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

dilanSachi removed the Skip GraalVM Check label

TharmiganK approved these changes

View reviewed changes

Contributor

TharmiganK left a comment

LGTM

dilanSachi merged commit d16a019 into ballerina-platform:master

8 of 10 checks passed

dilanSachi deleted the fix-lang-spec-deviation branch

July 12, 2023 10:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet