Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GraphQL File Upload Implementation #680

Merged

Conversation

DimuthuMadushan
Copy link
Contributor

Purpose

Fixes: #2838

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #680 (2d2fda8) into master (694613c) will increase coverage by 0.00%.
The diff coverage is 92.00%.

@@            Coverage Diff            @@
##             master     #680   +/-   ##
=========================================
  Coverage     93.35%   93.36%           
  Complexity      367      367           
=========================================
  Files            57       57           
  Lines          4094     4097    +3     
  Branches       2101     2104    +3     
=========================================
+ Hits           3822     3825    +3     
  Misses          243      243           
  Partials         29       29           
Impacted Files Coverage Δ
ballerina/listener_utils.bal 90.49% <92.00%> (+0.11%) ⬆️
ballerina/engine.bal 97.18% <0.00%> (-1.39%) ⬇️
ballerina/response_formatter.bal 95.83% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8adce4...2d2fda8. Read the comment docs.

docs/proposals/file_upload.md Outdated Show resolved Hide resolved
docs/spec/spec.md Outdated Show resolved Hide resolved
@ThisaruGuruge
Copy link
Member

Let's wait for @shafreenAnfar's response before merging this.

@shafreenAnfar
Copy link
Contributor

shafreenAnfar commented Apr 11, 2022

LGTM! Let's make sure impacted parties are informed if there is any.

@DimuthuMadushan DimuthuMadushan merged commit 3241ca7 into ballerina-platform:master Apr 11, 2022
@DimuthuMadushan DimuthuMadushan deleted the refactor-file-upload branch September 30, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor GraphQL File Upload Implementation
3 participants