Add Input Value List Support for GraphQL #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ballerina-graphql into parser-validation-for-inputs
…-ballerina-graphql into parser-validation-for-inputs
DimuthuMadushan
requested review from
shafreenAnfar and
ThisaruGuruge
as code owners
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
============================================
- Coverage 94.90% 94.59% -0.31%
- Complexity 297 335 +38
============================================
Files 54 53 -1
Lines 2981 3368 +387
Branches 1537 1748 +211
============================================
+ Hits 2829 3186 +357
- Misses 128 153 +25
- Partials 24 29 +5
Continue to review full report at Codecov.
|
compiler-plugin-tests/src/test/resources/ballerina_sources/invalid_service_26/service.bal
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/graphql/runtime/engine/Engine.java
Show resolved
Hide resolved
Comment on lines
70
to
72
| if (type.getTag() == TypeTags.ARRAY_TAG) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Why do we have to specifically check for the array types here? Is this check needed?
There was a problem hiding this comment.
When we get an array type input like float[][], type.Package value is not present. Due to that following if condition will cause to a NPE. if (type.getPackage().getOrg() == null || type.getPackage().getName() == null) {.
There was a problem hiding this comment.
Then let's add a check like this:
if (type.getPackage() == null) {
return false;
}
if (type.getPackage().getOrg() == null || type.getPackage().getName() == null) {
return false;
}…-ballerina-graphql into parser-validation-for-inputs
DimuthuMadushan
force-pushed
the
parser-validation-for-inputs
branch
from
cc24be1 to
e753748
Compare
Comment on lines
70
to
72
| if (type.getTag() == TypeTags.ARRAY_TAG) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Then let's add a check like this:
if (type.getPackage() == null) {
return false;
}
if (type.getPackage().getOrg() == null || type.getPackage().getName() == null) {
return false;
}
ThisaruGuruge
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: #1837
Fixes: #2133
Examples
Checklist